[FIX] Application: Fallback to manifest.appdescr_variant if manifest.json is not found #631
Conversation
…json is not found This fixes a regression presumably present since ui5-projevt 3.0.0, which prevented proper fallback to manifest.appdescr_variant in case no manifest.json is found in the project.
| @@ -124,15 +124,15 @@ class Application extends ComponentProject { | |||
| try { | |||
| return await this._getNamespaceFromManifestJson(); | |||
| } catch (manifestJsonError) { | |||
| if (manifestJsonError.code !== "ENOENT") { | |||
| if (manifestJsonError.cause?.code !== "ENOENT") { | |||
There was a problem hiding this comment.
In general, I don't like if the caller needs to know the potential structure of an exception chain. However, as this is inside the same module, it's acceptable.
Alternatively, the catch clause starting in line 224 could check for the ENOENT and re-throw the err "as is", without wrapping it. Both error messages anyhow have the same content (no added value).
For the caller this then would result in a direct check on the caught manifestJsonError.
There was a problem hiding this comment.
Good idea, somehow I missed that 👍
|
@matz3 Something like test/lib/specifications/types/Application.js#L488 ? The test might need some improvement as it didn't detect the issue that this PR fixes. [Update] The mentioned test stubbed the |
This is exactly what I did: https://github.com/SAP/ui5-project/pull/631/files#diff-59c51aa221f82a38efbda063367f94782ab12d1b9d63d9e94e3917ca43f89408R589 This assertion would have failed before the fix. |
|
Got it, thanks. |
|
Works like a charm, thank you! |
This fixes a regression presumably present since ui5-project v3.0.0,
which prevented proper fallback to manifest.appdescr_variant in case no
manifest.json is found in the project.